zlzhang0122 commented on a change in pull request #16637:
URL: https://github.com/apache/flink/pull/16637#discussion_r684066191



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java
##########
@@ -136,6 +135,8 @@ public void checkFailureCounter(CheckpointException 
exception, long checkpointId
                 // ignore
                 break;
 
+            case EXCEPTION:

Review comment:
       CheckpointFailureReason.EXCEPTION is also a kind of IOException may 
produced by StreamTaskNetworkInput.prepareSnapshot(), to keep the consistency, 
I think maybe we should moved it out of ignore. What do u think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to