zlzhang0122 commented on a change in pull request #16637:
URL: https://github.com/apache/flink/pull/16637#discussion_r685807958
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorCoordinatorCheckpoints.java
##########
@@ -121,14 +123,17 @@ private static void acknowledgeAllCoordinators(
final Throwable error =
checkpoint.isDisposed() ? checkpoint.getFailureCause()
: null;
+ CheckpointFailureReason reason =
CheckpointFailureReason.TRIGGER_CHECKPOINT_FAILURE;
Review comment:
I agree with @pnowojski that `acknowledgeAllCoordinators` is called very
early, and as far as I can see, `acknowledgeAllCoordinators` is used to take
checkpoint for `OperatorCoordinator` which is runing on JobMaster. So maybe we
can simply consider it as another kind of masterStates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
