beyond1920 commented on a change in pull request #16739:
URL: https://github.com/apache/flink/pull/16739#discussion_r684120157
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/WindowJoinTest.scala
##########
@@ -388,6 +388,7 @@ class WindowJoinTest extends TableTestBase {
| a,
| window_start,
| window_end,
+ | window_time,
Review comment:
Those unit tests in `WindowJoinTest` would fallback to the regular join
because they don't satisfy the condition to convert to window join. In the
previous version, if the input contains time attributes, exception would be
thrown out. So in the previous pr, I skip the time attributes in the select
clause.
I add back the time attributes in the select clause to test now join input
could contain time attributes fields because they would materialized in
`RelTimeIndicatorConveter ` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
