beyond1920 commented on a change in pull request #16739:
URL: https://github.com/apache/flink/pull/16739#discussion_r684121336
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/join/IntervalJoinTest.scala
##########
@@ -64,7 +64,7 @@ class IntervalJoinTest extends TableTestBase {
""".stripMargin)
/** There should exist exactly two time conditions **/
- @Test(expected = classOf[TableException])
+ @Test
Review comment:
Those cases in IntervalJoinTest would fallback to the regular join
because they don't satisfy the condition to convert to interval join. In the
previous version, they would throw exception because input contains time
attributes.
But in the new version, they could contain time attributes fields because
they would materialized in RelTimeIndicatorConveter now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
