tsreaper commented on a change in pull request #16740:
URL: https://github.com/apache/flink/pull/16740#discussion_r685729824
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/MathFunctionsITCase.java
##########
@@ -115,6 +115,14 @@
$("f0").round(2),
"ROUND(f0, 2)",
new BigDecimal("12345.12"),
- DataTypes.DECIMAL(8, 2).notNull()));
+ DataTypes.DECIMAL(8, 2).notNull()),
+ TestSpec.forFunction(BuiltInFunctionDefinitions.TRUNCATE)
+ .onFieldsWithData(new BigDecimal("123.456"))
+ // TRUNCATE(DECIMAL(6, 3) NOT NULL, 2) => DECIMAL(6,
2) NOT NULL
+ .testResult(
+ $("f0").truncate(2),
+ "TRUNCATE(f0, 2)",
+ new BigDecimal("123.45"),
+ DataTypes.DECIMAL(6, 2).notNull()));
Review comment:
Nice catch. With this in mind we shall keep using
`FlinkReturnTypes.ROUND_FUNCTION_NULLABLE` instead of modifying it. Still the
test cases should be moved to the appropriate place. You can also add this
special "truncate to zero" test case in your test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
