[ 
https://issues.apache.org/jira/browse/FLINK-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327604#comment-15327604
 ] 

Robert Metzger commented on FLINK-4051:
---------------------------------------

On the other hand, the Javadoc of take() states that the method is 
interruptible, and Flink is interrupting a thread if its not reacting to a 
cancel signal.
Therefore, I'm wondering if this is really an issue or not.

It seems that you are very eager to contribute to Flink. How about the 
following?
- You look into FLINK-4045 (without the renaming, just adding tests for the 
RabbitMQ connector)
- Once that is finished, we can add a specific test for RMQ source 
cancellation. Then, we can experiment with it and see how it reacts.

What do you think?

> RabbitMQ Source might not react to cancel signal
> ------------------------------------------------
>
>                 Key: FLINK-4051
>                 URL: https://issues.apache.org/jira/browse/FLINK-4051
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>            Reporter: Robert Metzger
>            Assignee: Subhankar Biswas
>
> As reported here 
> https://issues.apache.org/jira/browse/FLINK-3763?focusedCommentId=15322517&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15322517,
>  the RabbitMQ source might block forever / ignore the cancelling signal, if 
> its listening to an empty queue.
> Fix: call nextDelivery() with a timeout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to