AHeise commented on a change in pull request #16770: URL: https://github.com/apache/flink/pull/16770#discussion_r687062631
########## File path: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/OperatorIOMetricGroup.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.metrics.groups; + +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.MetricGroup; + +import javax.annotation.concurrent.NotThreadSafe; + +/** + * Metric group that contains shareable pre-defined IO-related metrics for operators. + * + * <p>All metrics can only be accessed in the main operator thread. + */ +@NotThreadSafe Review comment: You are right. I'm removing it. Definition of ThreadSafe ``` * The class to which this annotation is applied is thread-safe. This means that * no sequences of accesses (reads and writes to public fields, calls to public * methods) may put the object into an invalid state, regardless of the * interleaving of those actions by the runtime, and without requiring any * additional synchronization or coordination on the part of the caller. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
