pnowojski commented on a change in pull request #16774:
URL: https://github.com/apache/flink/pull/16774#discussion_r688437386
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -609,16 +586,13 @@ private boolean takeSnapshotSync(
Supplier<Boolean> isRunning)
throws Exception {
- for (final StreamOperatorWrapper<?, ?> operatorWrapper :
- operatorChain.getAllOperators(true)) {
- if (!enableCheckpointAfterTasksFinished &&
operatorWrapper.isClosed()) {
- env.declineCheckpoint(
- checkpointMetaData.getCheckpointId(),
- new CheckpointException(
- "Task Name" + taskName,
-
CheckpointFailureReason.CHECKPOINT_DECLINED_TASK_CLOSING));
- return false;
- }
+ if (!enableCheckpointAfterTasksFinished && operatorChain.isClosed()) {
Review comment:
I've added a separate hotfix commit to change this into
`checkState(!operatorChain.isClosed())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
