Airblader commented on a change in pull request #16813:
URL: https://github.com/apache/flink/pull/16813#discussion_r688439049
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonFormatFactory.java
##########
@@ -43,6 +43,7 @@
import java.util.HashSet;
import java.util.Set;
+import static
org.apache.flink.formats.json.JsonFormatOptions.ALLOW_NON_NUMERIC_NUMBERS;
Review comment:
Canal / Maxwell / Debezium shouldn't be importing from
`JsonFormatOptions`, those options should be redirected through
`CanalJsonFormatOptions` etc. This is already wrong for
`ENCODE_DECIMAL_AS_PLAIN_NUMBER`. Can you please fix these (and in the other
locations)?
These option classes are public API now, so users should expect to find all
supported options for Canal in CanalJsonFormatOptions, all supported options
for Maxwell in MaxwellJsonFormatOptions, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
