Airblader commented on a change in pull request #16813:
URL: https://github.com/apache/flink/pull/16813#discussion_r688857560
##########
File path:
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonFormatOptions.java
##########
@@ -73,6 +73,13 @@
.withDescription(
"Optional flag to specify whether to encode all
decimals as plain numbers instead of possible scientific notations, false by
default.");
+ public static final ConfigOption<Boolean> ALLOW_NON_NUMERIC_NUMBERS =
+ ConfigOptions.key("allow-non-numeric-numbers")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Optional flag to specify whether to deserialize
non-numeric number instead of failing, false by default.");
Review comment:
The above options should just be changed as well. Mentioning the default
in the description is OK if some explanation is needed. Otherwise it's just
duplicating the information in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
