PatrickRen commented on a change in pull request #16809:
URL: https://github.com/apache/flink/pull/16809#discussion_r688507078
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSource.java
##########
@@ -201,10 +221,32 @@ public ScanRuntimeProvider
getScanRuntimeProvider(ScanContext context) {
final TypeInformation<RowData> producedTypeInfo =
context.createTypeInformation(producedDataType);
- final FlinkKafkaConsumer<RowData> kafkaConsumer =
- createKafkaConsumer(keyDeserialization, valueDeserialization,
producedTypeInfo);
+ if (fallbackToFlinkKafkaConsumer) {
+ final FlinkKafkaConsumer<RowData> kafkaConsumer =
+ createKafkaConsumer(keyDeserialization,
valueDeserialization, producedTypeInfo);
+ return SourceFunctionProvider.of(kafkaConsumer, false);
+ }
- return SourceFunctionProvider.of(kafkaConsumer, false);
+ final KafkaSource<RowData> kafkaSource =
+ createKafkaSource(keyDeserialization, valueDeserialization,
producedTypeInfo);
+
+ return new DataStreamScanProvider() {
Review comment:
Currently ```SourceProvider``` doesn't support watermark pushdown, so I
have to use DataStreamSourceProvider for now:
https://github.com/apache/flink/blob/bc984f41c7d18d88a438ed071f563ac0bc5bd005/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java#L98-L103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
