PatrickRen commented on a change in pull request #16809:
URL: https://github.com/apache/flink/pull/16809#discussion_r689324265
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSource.java
##########
@@ -137,6 +148,11 @@
/** Flag to determine source mode. In upsert mode, it will keep the
tombstone message. * */
protected final boolean upsertMode;
+ /** Whether to use legacy {@link FlinkKafkaConsumer} for runtime
execution. */
+ protected final boolean fallbackToFlinkKafkaConsumer;
Review comment:
Sorry for changing my mind in last minutes. I removed this switch in
order to be aligned with sink side. Having the "kafka-legacy" for source but
not sink looks weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
