NicoK opened a new pull request #16848:
URL: https://github.com/apache/flink/pull/16848


   ## What is the purpose of the change
   
   This allows further tuning RocksDB's logger with the following three new 
parameters:
   - `state.backend.rocksdb.log.max-file-size` sets the max log file size
   - `state.backend.rocksdb.log.file-num` configures the number of logging 
files to keep
   - `state.backend.rocksdb.log.dir` sets the directory of the logging files, 
e.g. to put these logs onto a (separate) volume that may not be local and is 
retained after container shutdown for debugging purposes
   
   ## Brief change log
     - add the options above to `RocksDBConfigurableOptions` with no default 
values (not changing the current behaviour and instead relying on RocksDB's 
defaults)
     - extend `DefaultConfigurableOptionsFactory` to deal with the new option 
settings from configuration and via getters/setters
     - extend `RocksDBStateBackendConfigTest` to verify valid and invalid 
settings.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Running the `RocksDBStateBackendConfigTest` test
   - Tested by running a test Flink job in a cluster with the following config:
   ```
   state.backend: rocksdb
   state.backend.rocksdb.log.level: DEBUG_LEVEL
   state.backend.rocksdb.log.max-file-size: 50KB
   state.backend.rocksdb.log.file-num: 2
   state.backend.rocksdb.log.dir: /tmp/flink/log/
   ```
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no** (adds 3 new config options though)
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper:  **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **yes**
     - If yes, how is the feature documented? docs + JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to