NicoK commented on a change in pull request #16848:
URL: https://github.com/apache/flink/pull/16848#discussion_r689784105
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
##########
@@ -93,6 +93,31 @@
NUM_INFO_LOG_LEVELS.name(),
HEADER_LEVEL.name()));
+ public static final ConfigOption<MemorySize> LOG_MAX_FILE_SIZE =
+ key("state.backend.rocksdb.log.max-file-size")
+ .memoryType()
+ .noDefaultValue()
+ .withDescription(
+ "The maximum size of RocksDB's file used for
logging. "
+ + "If the log files becomes larger than
this, a new file will be created."
+ + "If 0 (default RocksDB setting), all
logs will be written to one log file.");
+
+ public static final ConfigOption<Integer> LOG_FILE_NUM =
+ key("state.backend.rocksdb.log.file-num")
+ .intType()
+ .noDefaultValue()
+ .withDescription(
+ "The maximum number of files RocksDB should keep
for logging (default RocksDB setting: 1000).");
+
+ public static final ConfigOption<String> LOG_DIR =
+ key("state.backend.rocksdb.log.dir")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "The directory for RocksDB's logging files. "
+ + "If empty (default RocksDB setting), log
files will be in the same directory as data files. "
+ + "If non-empty, this directory will be
used and the data directory's absolute path will be used as the prefix of the
log file name.");
+
Review comment:
I thought, it was enough to use "logging" instead of "log", but using
"information logging" also works; I'll adapt it accordingly (also in the
description of `state.backend.rocksdb.log.level`).
Do you think, we need to change the config name as well (will be difficult
for log.level because that was already merged for 1.13)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
