wsry commented on pull request #16844: URL: https://github.com/apache/flink/pull/16844#issuecomment-900827949
> @wsry thanks for your changes. They look correct for me but I have a couple of notices. First of all, I suggest splitting this one commit into two: the first one with the refactoring, the second one with the fixing of the bug. > Secondly, I don't really understand the current contract of `fail` and `close`. You can take a look at my comments in PR for more details. I think it make sense that we split the patch into two commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
