tsreaper commented on a change in pull request #16823:
URL: https://github.com/apache/flink/pull/16823#discussion_r692625950
##########
File path:
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterOptions.java
##########
@@ -54,7 +54,14 @@
ConfigOptions.key("deleteOnShutdown")
.defaultValue(true)
.withDescription(
- "Specifies whether to delete metrics from the
PushGateway on shutdown.");
+ Description.builder()
+ .text(
+ "Specifies whether to delete
metrics from the PushGateway on shutdown."
+ + " Flink will try its
best to delete the metrics but this is not guaranteed. See here %s",
+ LinkElement.link(
+
"https://issues.apache.org/jira/browse/FLINK-13787";,
+ "for more details."))
Review comment:
The link should be attached to "here", not to "for more details".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
