tsreaper commented on a change in pull request #16823:
URL: https://github.com/apache/flink/pull/16823#discussion_r692058240
##########
File path:
docs/layouts/shortcodes/generated/prometheus_push_gateway_reporter_configuration.html
##########
@@ -12,7 +12,7 @@
<td><h5>deleteOnShutdown</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Specifies whether to delete metrics from the PushGateway on
shutdown.</td>
+ <td>Specifies whether to delete metrics from the PushGateway on
shutdown. but sometime metrics will not be deleted, see <a
href="https://issues.apache.org/jira/browse/FLINK-13787";>PrometheusPushGatewayReporter
does not cleanup TM metrics when run on kubernetes</a></td>
Review comment:
I'd like to emphasize in the docs that this config only "tries" to
delete the metrics, but it is not guaranteed. For example
> Specifies whether to delete metrics from the PushGateway on shutdown.
Flink will try its best to delete the metrics but this is not guaranteed. See
<a href="https://issues.apache.org/jira/browse/FLINK-13787";>here</a> for more
details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
