Airblader commented on a change in pull request #16902:
URL: https://github.com/apache/flink/pull/16902#discussion_r692672356
##########
File path: flink-runtime-web/web-dashboard/src/app/interfaces/safe-any.ts
##########
@@ -0,0 +1,2 @@
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export type SafeAny = any;
Review comment:
We should immediately mark this as deprecated. `SafeAny` is not safe at
all, it's a hack that silences a correct warning/error. It would be better to
use `unknown` instead everywhere, however that is a separate change as it isn't
a drop-in replacement.
##########
File path: flink-runtime-web/web-dashboard/.eslintignore
##########
@@ -0,0 +1,37 @@
+.idea
+gen
+web
+tsc-out
+dist
+
+# Logs
+logs
+*.log
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+
+# Dependency directories
+node_modules/
+
+# TypeScript cache
+*.tsbuildinfo
+
+# Optional npm cache directory
+.npm
+
+# Optional eslint cache
+.eslintcache
+
+# Yarn Integrity file
+.yarn-integrity
Review comment:
We don't use yarn, do we (also below for `.yarn`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
