yangjunhan commented on pull request #16902: URL: https://github.com/apache/flink/pull/16902#issuecomment-902536757
> Thanks @yangjunhan for the PR! It'll be a great improvement to Flink UI to have proper linting set up. I will take a closer look next week. > > However, it would be good if we could split this into different commits, in particular actually applying all linting fixes should be its own commit. This would make the review easier, allow us to regenerate that commit upon conflicts and maybe even add it to `.git-blame-ignore-revs` (during merging). Since you mentioned the vulnerability fixes here, anything not related to tslint/eslint itself should also be a separate commit as those changes are important and useful on their own. > > Another note: this currently isn't checked in the CI, correct? We need to make sure that the CI actually verifies using eslint as well (again, as a separate commit). Thank you for your advice @Airblader. Now I have split it into several individual commits and hopefully they make sense to you. Regarding the `SafeAny` issue, I already marked it as deprecated, and perhaps we will remove it in the near future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
