zhuzhurk commented on a change in pull request #16959:
URL: https://github.com/apache/flink/pull/16959#discussion_r695431542
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java
##########
@@ -117,7 +117,7 @@ public void increaseResourceRequirementsBy(ResourceCounter
increment) {
@Override
public void decreaseResourceRequirementsBy(ResourceCounter decrement) {
- if (decrement.isEmpty()) {
+ if (decrement.isEmpty() || totalResourceRequirements.isEmpty()) {
Review comment:
I guess what @zentol means is that if we decrease a non-empty
`ResourceCounter` when the `totalResourceRequirements` is not empty, it is an
unexpected bug and needs to be exposed.
So I think we should add a check here and also fix
`ResourceCounter#updateNewValue()` to throw exception if negative result
happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
