zlzhang0122 commented on a change in pull request #16847:
URL: https://github.com/apache/flink/pull/16847#discussion_r695714793
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerDriverTest.java
##########
@@ -627,9 +605,12 @@ protected void
validateReleaseResources(Collection<YarnWorkerNode> workerNodes)
verifyFutureCompleted(releaseAssignedContainerFuture);
}
- ContainerStatus createTestingContainerCompletedStatus(final
ContainerId containerId) {
+ ContainerStatus createTestingContainerCompletedStatus(ContainerStatus
containerStatus) {
return new TestingContainerStatus(
Review comment:
I think `ContainerStatusPBImpl` is a implementation class which contains
some logic of YARN, `TestingContainerStatus` is just for test and can simplify
the usage and reduce much of unnecessary check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
