zlzhang0122 commented on a change in pull request #16847:
URL: https://github.com/apache/flink/pull/16847#discussion_r695724910



##########
File path: 
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerDriverTest.java
##########
@@ -627,9 +605,12 @@ protected void 
validateReleaseResources(Collection<YarnWorkerNode> workerNodes)
             verifyFutureCompleted(releaseAssignedContainerFuture);
         }
 
-        ContainerStatus createTestingContainerCompletedStatus(final 
ContainerId containerId) {
+        ContainerStatus createTestingContainerCompletedStatus(ContainerStatus 
containerStatus) {
             return new TestingContainerStatus(

Review comment:
       Actaully, I don't know, maybe for clearfy it's used for test? I also 
think that we can replace `TestingContainerStatus` with `ContainerStatusPBImpl`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to