Airblader commented on a change in pull request #16980:
URL: https://github.com/apache/flink/pull/16980#discussion_r696419462
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.less
##########
@@ -32,12 +32,15 @@ nz-table {
flink-monaco-editor {
height: calc(~"100vh - 346px");
+
&.subtask {
height: 300px;
}
}
.expand-td {
+ display: block;
+ width: 100%;
Review comment:
width 100% is the default for block elements. Why is this needed?
##########
File path:
flink-runtime-web/web-dashboard/src/app/share/common/monaco-editor/monaco-editor.component.ts
##########
@@ -74,7 +74,7 @@ export class MonacoEditorComponent implements AfterViewInit,
OnDestroy {
ngAfterViewInit() {
if ((window as any).monaco) {
- this.setupMonaco();
+ setTimeout(() => this.setupMonaco());
Review comment:
Could you quickly you explain why we need to delay this by a tick now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
