Airblader commented on a change in pull request #16980:
URL: https://github.com/apache/flink/pull/16980#discussion_r696462684
##########
File path:
flink-runtime-web/web-dashboard/src/app/share/common/monaco-editor/monaco-editor.component.ts
##########
@@ -74,7 +74,7 @@ export class MonacoEditorComponent implements AfterViewInit,
OnDestroy {
ngAfterViewInit() {
if ((window as any).monaco) {
- this.setupMonaco();
+ setTimeout(() => this.setupMonaco());
Review comment:
Thanks. I'm OK with this as a hotfix, however it's more of a workaround
and the component should probably be smart enough to only rely on its
dimensions when it's actually been rendered / relayout itself when that
changes. I've also raised a FLINK issue to investigate removing this custom
component altogether for the one now included in ng-zorro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
