zentol opened a new pull request #17059: URL: https://github.com/apache/flink/pull/17059
When a slot is released in the `DefaultDeclarativeSlotPool` then the pool returns a `ResourceCounter` describing which requirements said slots were fulfilling, such that the `DeclarativeSlotPoolBridge` can then reduce the requirements accordingly. The pool however did not take into account that the released slot may already be free; in that case the requirements were already reduced previously (at the time the slot was freed); according to the returned `ResourceCounter` the slot was nevertheless still fulfilling the previous requirement, which lead to a requirement reduction being applied twice. The pool now checks for all slots that are released whether they are currently reserved or not, and only determines the fulfilled requirements for the reserved ones. To determine whether a slot was reserved or not `AllocatedSlotPool#removeSlots` was modified to also return the reservation status. With this change the behavior of `#releaseSlot(s)` and `#freeReservedSlot` are much more aligned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
