mas-chen commented on a change in pull request #17007:
URL: https://github.com/apache/flink/pull/17007#discussion_r699029340
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/FrontMetricGroup.java
##########
@@ -72,8 +74,15 @@ public MetricGroup getWrappedMetricGroup() {
@Override
public Map<String, String> getAllVariables() {
- return parentMetricGroup.getAllVariables(
- this.settings.getReporterIndex(),
this.settings.getExcludedVariables());
+ Map<String, String> allVariables =
+ parentMetricGroup.getAllVariables(
+ this.settings.getReporterIndex(),
this.settings.getExcludedVariables());
+
+ if (this.settings.getAdditionalVariables().isEmpty()) {
+ return allVariables;
+ }
+
+ return new CompositeMap(allVariables,
this.settings.getAdditionalVariables());
Review comment:
@zentol Thanks for the `CompositeMap` suggestion. I didn't add a mutator
for collisions here--I figure throwing an exception is acceptable since we
wouldn't want users overriding Flink internal metric variables.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java
##########
@@ -116,6 +117,34 @@ public ReporterSetup(
}
}
+ public Map<String, String> tryGetAdditionalVariables() {
+ String additionalVariablesMap =
+ configuration.getString(
+ ConfigConstants.METRICS_REPORTER_ADDITIONAL_VARIABLES,
null);
+ if (additionalVariablesMap == null) {
+ return Collections.emptyMap();
+ } else {
+ try {
+ final Map<String, String> additionalVariables = new
HashMap<>();
+ for (String variableEntry : additionalVariablesMap.split(","))
{
+ String[] tagEntry = variableEntry.split(":");
Review comment:
This is neat!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
