mas-chen commented on a change in pull request #17007:
URL: https://github.com/apache/flink/pull/17007#discussion_r699892125
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java
##########
@@ -284,12 +304,19 @@ private static ReporterSetup createReporterSetup(
try {
Optional<MetricReporter> metricReporterOptional =
loadReporter(reporterName, reporterConfig,
reporterFactories);
+
+ Map<String, String> additionalVariables =
reporterConfig.get(ADDITIONAL_VARIABLES);
Review comment:
Good catch, my original implementation had this logic. Must've missed it
while refactoring the parsing logic and I had a failing unit test written to
validate this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
