alpinegizmo commented on a change in pull request #36:
URL: https://github.com/apache/flink-training/pull/36#discussion_r700294637
##########
File path:
long-ride-alerts/src/solution/java/org/apache/flink/training/solutions/longrides/LongRidesSolution.java
##########
@@ -115,31 +115,31 @@ public void processElement(TaxiRide ride, Context
context, Collector<Long> out)
throws Exception {
TaxiRide firstRideEvent = rideState.value();
-
if (firstRideEvent == null) {
+ // whatever event comes first, remember it
rideState.update(ride);
if (ride.isStart) {
+ // we will use this timer to check for rides that have
gone on too long and may
+ // not yet have an END event (or the END event could be
missing)
context.timerService().registerEventTimeTimer(getTimerTime(ride));
- } else {
- if (rideTooLong(ride)) {
- out.collect(ride.rideId);
- }
}
Review comment:
It's not possible to handle missing START events. Those START events are
now the only source of knowledge about when the ride started, so it's not
possible to know how long the ride was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
