[jira] [Commented] (FLINK-4090) Close of OutputStream should be in finally clause in FlinkYarnSessionCli#writeYarnProperties()

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338891#comment-15338891
 ] 

ASF GitHub Bot commented on FLINK-4090:
---------------------------------------

GitHub user f7753 opened a pull request:

    https://github.com/apache/flink/pull/2132

    [FLINK-4090] Close of OutputStream should be in finally clause in Fli…

    `try {
          OutputStream out = new FileOutputStream(propertiesFile);
          properties.store(out, "Generated YARN properties file");
          out.close();
        } catch (IOException e) {`
    Move the close of out in finally clause.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/f7753/flink flink4090

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2132
    
----
commit 0484760557dc31dfe117dd639ffe724169eefe2b
Author: MaBiao <mabiao...@gmail.com>
Date:   2016-06-20T02:00:02Z

    [FLINK-4090] Close of OutputStream should be in finally clause in 
FlinkYarnSesionCli#writeYarnProperties()

----


> Close of OutputStream should be in finally clause in 
> FlinkYarnSessionCli#writeYarnProperties()
> ----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-4090
>                 URL: https://issues.apache.org/jira/browse/FLINK-4090
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>     try {
>       OutputStream out = new FileOutputStream(propertiesFile);
>       properties.store(out, "Generated YARN properties file");
>       out.close();
>     } catch (IOException e) {
> {code}
> The close of out should be in finally cluase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)