[jira] [Commented] (FLINK-4090) Close of OutputStream should be in finally clause in FlinkYarnSessionCli#writeYarnProperties()

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339688#comment-15339688
 ] 

ASF GitHub Bot commented on FLINK-4090:
---------------------------------------

Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2132
  
    Merging with a slight change to use the `Closeable` feature:
    
    ```java
                try (final OutputStream out = new 
FileOutputStream(propertiesFile)) {
                        properties.store(out, "Generated YARN properties file");
                } catch (IOException e) {
                        throw new RuntimeException("Error writing the 
properties file", e);
                }
    ```


> Close of OutputStream should be in finally clause in 
> FlinkYarnSessionCli#writeYarnProperties()
> ----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-4090
>                 URL: https://issues.apache.org/jira/browse/FLINK-4090
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>     try {
>       OutputStream out = new FileOutputStream(propertiesFile);
>       properties.store(out, "Generated YARN properties file");
>       out.close();
>     } catch (IOException e) {
> {code}
> The close of out should be in finally cluase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)