stevenzwu commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r701362547
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceEnumeratorStateSerializer.java
##########
@@ -54,12 +44,9 @@ public int getVersion() {
try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
DataOutputStream out = new DataOutputStream(baos)) {
out.writeInt(enumState.getCurrentSourceIndex());
- SimpleVersionedSerializer<Object> serializer =
- serializerOf(enumState.getCurrentSourceIndex());
- out.writeInt(serializer.getVersion());
- byte[] enumStateBytes =
serializer.serialize(enumState.getWrappedState());
- out.writeInt(enumStateBytes.length);
- out.write(enumStateBytes);
+ out.writeInt(enumState.wrappedStateSerializerVersion());
+ out.writeInt(enumState.getWrappedState().length);
Review comment:
integer would limit the state size to 2 GB. not sure if we need to worry
about it or not. It can happen if the historical storage (like HDFS or Iceberg)
have many files/splits for the booststrap scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
