AHeise commented on a change in pull request #17111:
URL: https://github.com/apache/flink/pull/17111#discussion_r701406994
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/hybrid/HybridSourceEnumeratorStateSerializer.java
##########
@@ -54,12 +44,9 @@ public int getVersion() {
try (ByteArrayOutputStream baos = new ByteArrayOutputStream();
DataOutputStream out = new DataOutputStream(baos)) {
out.writeInt(enumState.getCurrentSourceIndex());
- SimpleVersionedSerializer<Object> serializer =
- serializerOf(enumState.getCurrentSourceIndex());
- out.writeInt(serializer.getVersion());
- byte[] enumStateBytes =
serializer.serialize(enumState.getWrappedState());
- out.writeInt(enumStateBytes.length);
- out.write(enumStateBytes);
+ out.writeInt(enumState.wrappedStateSerializerVersion());
+ out.writeInt(enumState.getWrappedState().length);
Review comment:
Please note that the limit would not be the integer to represent the
size but rather the byte[] array that cannot go beyond that. We do not have 64
bit array https://www.nayuki.io/page/large-arrays-proposal-for-java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
