dmvk commented on a change in pull request #17107:
URL: https://github.com/apache/flink/pull/17107#discussion_r701720488
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -593,7 +593,10 @@ public void deploy() throws JobException {
if (failure == null) {
vertex.notifyCompletedDeployment(this);
} else {
- if (failure instanceof TimeoutException) {
+ final Throwable actualFailure =
+
ExceptionUtils.stripCompletionException(failure);
+
+ if (actualFailure instanceof
TimeoutException) {
Review comment:
Should we have a failing test case for this? If I understand this
correctly, this code path has actually never worked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
