dianfu commented on a change in pull request #16798:
URL: https://github.com/apache/flink/pull/16798#discussion_r701729031
##########
File path: docs/content/docs/connectors/datastream/rabbitmq.md
##########
@@ -126,6 +126,28 @@ val stream = env
.setParallelism(1) // non-parallel source is only required
for exactly-once
```
{{< /tab >}}
Review comment:
Could you also add these documentation under docs.zh?
##########
File path: flink-python/pyflink/datastream/connectors.py
##########
@@ -1074,3 +1074,179 @@ def for_row_format(base_path: str, encoder: Encoder) ->
'FileSink.RowFormatBuild
return FileSink.RowFormatBuilder(
JFileSink.forRowFormat(JPath(base_path), encoder._j_encoder))
+
+
+class RMQConnectionConfig(object):
Review comment:
Declare these classes in the __all__ list to make them public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]