dianfu commented on a change in pull request #16798:
URL: https://github.com/apache/flink/pull/16798#discussion_r706975452
##########
File path: flink-connectors/flink-connector-rabbitmq/pom.xml
##########
@@ -92,4 +92,31 @@ under the License.
</dependencies>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <configuration>
+ <artifactSet>
+ <includes
combine.children="append">
+
<include>com.rabbitmq:amqp-client</include>
+ </includes>
+ </artifactSet>
+ <relocations>
+ <relocation>
+
<pattern>com.rabbitmq</pattern>
+
<shadedPattern>org.apache.flink.rabbitmq.shaded.com.rabbitmq</shadedPattern>
+ </relocation>
+ </relocations>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+
Review comment:
This makes the RabbitMQ connector becoming a fat jar. We need to do the
following for a fat jar:
- Usually it will create a fat jar in a separate module, e.g
flink-sql-connector-kinesis vs flink-connector-kinesis
- Need to add a NOTICE file which declares the bundled libraries and their
licenses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
