scudellari opened a new pull request #17227:
URL: https://github.com/apache/flink/pull/17227


   ## What is the purpose of the change
   When running on JDK11 
[JDK-8237858](https://bugs.openjdk.java.net/browse/JDK-8237858) can cause 
SocketTimeoutExceptions to be thrown during
   ServerSocket.accept() calls, even when configured with an infinite timeout.
   This change works around this issue by catching these erroneous exceptions
   and retrying indefinitely.
   
   ## Brief change log
   - Added `acceptWithoutTimeout` method to `NetUtils` that calls 
`ServerSocket.accept()` and suppresses `SocketTimeoutException`s. Added a unit 
test to cover the new method.
   - Migrated all `ServerSocket.accept()` calls to use `acceptWithoutTimeout`, 
with exception to the `EchoServer` test as it sets an explicit timeout.
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   - Added unit test to verify `acceptWithoutTimeout` suppresses 
`SocketTimeoutException`s.
   - Most migrations touched unit tests directly. I have run those to verify 
they still pass.
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **yes - blob server**
     - The S3 file system connector: **no**
   
   ## Documentation
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to