zentol commented on a change in pull request #17227:
URL: https://github.com/apache/flink/pull/17227#discussion_r705690463
##########
File path: flink-core/src/test/java/org/apache/flink/util/NetUtilsTest.java
##########
@@ -49,6 +58,30 @@ public void testParseHostPortAddress() {
assertEquals(socketAddress,
NetUtils.parseHostPortAddress("foo.com:8080"));
}
+ @Test
+ public void testAcceptWithoutTimeout() throws IOException {
+ // Validates that acceptWithoutTimeout suppresses all
SocketTimeoutExceptions
+ ServerSocket serverSocket = mock(ServerSocket.class);
Review comment:
We had a fair amount of maintenance overhead due to mockito in the past;
instead we aim to write code in such a way that mocking isn't necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
