Airblader commented on a change in pull request #17264:
URL: https://github.com/apache/flink/pull/17264#discussion_r709830893
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java
##########
@@ -131,8 +144,11 @@ default String getInsertIntoStatement(String tableName,
String[] fieldNames) {
}
/**
- * Get update one row statement by condition fields, default not use limit
1, because limit 1 is
- * a sql dialect.
+ * Constructs the dialects update statement for a single row with the
given condition.
+ *
+ * <p>The default implementation does not use {@code LIMIT 1} as limit is
dialect specific.
+ *
+ * @return A single row update statement.
*/
default String getUpdateStatement(
Review comment:
Or at least we shouldn't default-implement "bad" implementations (IMO),
or actively document this on the interface itself ("we're giving you
convenience to do little to get started, but most of it you probably want to
change").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
