Airblader commented on a change in pull request #17264:
URL: https://github.com/apache/flink/pull/17264#discussion_r710267563
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/mysql/MySQLDialect.java
##########
@@ -29,7 +30,7 @@
import java.util.stream.Collectors;
/** JDBC dialect for MySQL. */
-public class MySQLDialect extends AbstractDialect {
+class MySQLDialect extends AbstractDialect {
Review comment:
I think rather we don't have strong enough rules on this in the project,
see https://github.com/apache/flink/pull/17186#discussion_r705312290.
For my architectural tests I'll have to address this with the community
somehow, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
