[
https://issues.apache.org/jira/browse/FLINK-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344554#comment-15344554
]
ASF GitHub Bot commented on FLINK-3995:
---------------------------------------
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2148
[FLINK-3995] [build] Make test utils properly available and fix Maven
dependencies
This pull request subsumes https://github.com/apache/flink/pull/2092.
I added a commit to Stephan's pull request fixing all the build errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink test_utils
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2148
----
commit f30b51d69cdf870f920fccbe96c2e00295ade226
Author: Stephan Ewen <[email protected]>
Date: 2016-05-30T18:56:05Z
[FLINK-3995] [build] Properly structure test scopes and dependencies
Makes the JUnit test utils (TestLogger, retry rules, ...) properly
available to
other projects without the 'flink-core' test-jar, via the
'flink-test-utils-junit' project.
Makes the ForkableMiniCluster, TestEnvironment, and other test utilities
available in the 'main'
scope of the 'flink-test-utils' project.
Creates a 'flink-test-utils-parent' project that holds the
'flink-test-utils-junit' and
'flink-test-utils' project.
Also moves some tests between projects and inlines some very simple utility
functions in
order to simplify some test jar dependencies.
commit 82bd8b88190ab50b15be2716f0ae84afafadfffb
Author: Stephan Ewen <[email protected]>
Date: 2016-06-11T00:14:07Z
[FLINK-3995] [build] flink-test-utils also contains the streaming test
utilities.
Test utilities include the StreamingMultipleProgramsTestBase and
StreamingTestEnvironment.
This moves the ITCases for streaming into 'flink-tests' to achieve that.
commit 59113586caa12a9b7c943b4c4322d00df223d691
Author: Robert Metzger <[email protected]>
Date: 2016-06-20T12:20:59Z
Make the build pass
----
> Properly Structure Test Utils and Dependencies
> ----------------------------------------------
>
> Key: FLINK-3995
> URL: https://issues.apache.org/jira/browse/FLINK-3995
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.0.2
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.1.0
>
>
> All valuable test utils are only found in {{test-jars}}, but should be found
> in the {{compile}} scope of the test util projects.
> - TestLogger
> - RetryRules
> - MiniClusters
> - TestEnvironments
> - ...
> Additionally, we have dependencies where the {{compile}} scope of some
> projects depends on {{test-jars}} of other projects. That can create problems
> in some builds and with some tools.
> Here is how we can fix that:
> - Create a {{flink-testutils-core}} project, which has the test utils
> currently contained in the {{flink-core}} {{test-jar}} in the main scope.
> That means the {{flink-core test-jar}} is not needed by other projects any
> more.
> - Make the Mini Cluster available in {{flink-test-utils}} main scope.
> - To remove the test-jar dependency on {{flink-runtime}} from the
> {{flink-test-utils}} project, we need to move the test actor classes to the
> main scope in {{flink-runtime}}.
> This is related to FLINK-1827 (a followup).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
