sjwiesman commented on pull request #17264: URL: https://github.com/apache/flink/pull/17264#issuecomment-921099358
@Airblader and @mfussenegger thanks for the review. I've tried to address all the comments. I changed the service loader to work more similar to FactoryUtils and error if there isn't exactly one compatible dialect and shifted a lot of things from JdbcDialct to AbstractDialect with hopefully better javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
