dawidwys commented on a change in pull request #31:
URL: https://github.com/apache/flink-benchmarks/pull/31#discussion_r710853420
##########
File path: src/main/java/org/apache/flink/benchmark/MultipleInputBenchmark.java
##########
@@ -36,18 +50,20 @@
import org.openjdk.jmh.runner.options.OptionsBuilder;
import org.openjdk.jmh.runner.options.VerboseMode;
-public class MultipleInputBenchmark extends BenchmarkBase {
+import java.util.concurrent.CompletableFuture;
+public class MultipleInputBenchmark extends BenchmarkBase {
public static final int RECORDS_PER_INVOCATION =
TwoInputBenchmark.RECORDS_PER_INVOCATION;
public static final int ONE_IDLE_RECORDS_PER_INVOCATION =
TwoInputBenchmark.ONE_IDLE_RECORDS_PER_INVOCATION;
+ public static final int CHAINED_IDLE_RECORDS_PER_INVOCATION = 3000;
Review comment:
1. I forgot to move a flag from the UT and thus the chaining was not
applied in the benchmark, sorry for that.
2. Yes, I am sure it fixes it. With the flag you can see a difference
3. I picked a significantly smaller number to give the benchmark a chance to
finish with the old code. With 6 digit number of records, I am afraid it would
not finish (with 5 digits it already goes into minutes for a single iteration)
(Every record adds an entry onto the CompletableFuture stack which needs to be
iterated over at the end.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
