dawidwys commented on a change in pull request #31:
URL: https://github.com/apache/flink-benchmarks/pull/31#discussion_r710871559
##########
File path: src/main/java/org/apache/flink/benchmark/MultipleInputBenchmark.java
##########
@@ -36,18 +50,20 @@
import org.openjdk.jmh.runner.options.OptionsBuilder;
import org.openjdk.jmh.runner.options.VerboseMode;
-public class MultipleInputBenchmark extends BenchmarkBase {
+import java.util.concurrent.CompletableFuture;
+public class MultipleInputBenchmark extends BenchmarkBase {
public static final int RECORDS_PER_INVOCATION =
TwoInputBenchmark.RECORDS_PER_INVOCATION;
public static final int ONE_IDLE_RECORDS_PER_INVOCATION =
TwoInputBenchmark.ONE_IDLE_RECORDS_PER_INVOCATION;
+ public static final int CHAINED_IDLE_RECORDS_PER_INVOCATION = 3000;
Review comment:
3000 records
* without the fix:
```
Result
"org.apache.flink.benchmark.MultipleInputBenchmark.multiInputChainedIdleSource":
4.352 ±(99.9%) 0.174 ops/ms [Average]
(min, avg, max) = (4.003, 4.352, 5.241), stdev = 0.260
CI (99.9%): [4.179, 4.526] (assumes normal distribution)
```
* with the fix
```
Result
"org.apache.flink.benchmark.MultipleInputBenchmark.multiInputChainedIdleSource":
7.802 ±(99.9%) 0.082 ops/ms [Average]
(min, avg, max) = (7.608, 7.802, 8.243), stdev = 0.123
CI (99.9%): [7.720, 7.884] (assumes normal distribution)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
