cuibo01 commented on a change in pull request #17332:
URL: https://github.com/apache/flink/pull/17332#discussion_r715475502
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java
##########
@@ -142,4 +143,16 @@
*/
String getSelectFromStatement(
String tableName, String[] selectFields, String[] conditionFields);
+
+ /** Create catalog instance. */
+ default AbstractJdbcCatalog createCatalog(
+ String catalogName,
Review comment:
> Otherwise the other ticket will fall through the cracks and this gets
released as-is. I'm not a committer, though, this is just my opinion.
i am sorry, i dont understand why can not we merge the PR first and then
create a new ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
