AHeise commented on a change in pull request #17351:
URL: https://github.com/apache/flink/pull/17351#discussion_r716633195
##########
File path:
flink-core/src/main/java/org/apache/flink/api/connector/sink/SinkWriter.java
##########
@@ -63,6 +63,9 @@ default void writeWatermark(Watermark watermark) throws
IOException, Interrupted
*
* <p>This will be called before we checkpoint the Writer's state in
Streaming execution mode.
*
+ * <p>In case the sink implements a 1-phase commit protocol, this method
should trigger the
Review comment:
I wonder if this is really self-explanatory. How about
```suggestion
<p>In case the sink has no explicit committer, this method is still called
to allow the writer to implement a 1-phase commit protocol.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
