dawidwys commented on pull request #32:
URL: https://github.com/apache/flink-benchmarks/pull/32#issuecomment-928058796


   Ok, I found the issue with unaligned checkpoints. They were dropped silently 
because the checkpointing was not enabled. There is a check in 
`org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator#getCheckpointingMode`
 which switches the Checkpointing mode to `AT_LEAST_ONCE` which in turn 
disables unaligned checkpoints (`StreamingJobGraphGenerator:265).
   
   Unforunately it's not that perfect, as the `ALIGNED` checkpoint do not match 
the math anymore. Or do they?
   
   ```
   Benchmark                                                                    
        (mode)    Mode   Cnt     Score    Error  Units
   CheckpointingTimeBenchmark.checkpointSingleInput                             
       ALIGNED  sample    19   878.707 ± 71.026  ms/op
   CheckpointingTimeBenchmark.checkpointSingleInput                             
     UNALIGNED  sample  4051     2.465 ±  0.080  ms/op
   CheckpointingTimeBenchmark.checkpointSingleInput                             
   ALTERNATING  sample    82   132.851 ±  6.456  ms/op
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to