zentol commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r717315877
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/main/java/org/apache/flink/tests/util/kafka/LocalStandaloneKafkaResource.java
##########
@@ -89,7 +89,7 @@
private static String getKafkaDownloadUrl(final String kafkaVersion) {
return String.format(
- "https://archive.apache.org/dist/kafka/%s/kafka_2.11-%s.tgz";,
+ "https://archive.apache.org/dist/kafka/%s/kafka_2.12-%s.tgz";,
Review comment:
technically this doesn't require changes because it's an entirely
separate application
##########
File path: pom.xml
##########
@@ -877,7 +830,7 @@ under the License.
</properties>
<activation>
<property>
- <name>scala-2.12</name>
+ <name>!scala-2.11</name>
Review comment:
maybe use some magic property name that is unlikely to be used because
there could be scripts that accidentally set `-Dscala-2.11`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
