zentol commented on a change in pull request #14544:
URL: https://github.com/apache/flink/pull/14544#discussion_r718431519
##########
File path: flink-dist/src/main/resources/META-INF/NOTICE
##########
@@ -29,11 +29,11 @@ See bundled license files for details.
The following dependencies all share the same BSD license which you find under
licenses/LICENSE.scala.
-- org.scala-lang:scala-compiler:2.11.12
-- org.scala-lang:scala-library:2.11.12
-- org.scala-lang:scala-reflect:2.11.12
-- org.scala-lang.modules:scala-parser-combinators_2.11:1.1.1
-- org.scala-lang.modules:scala-xml_2.11:1.0.5
+- org.scala-lang:scala-compiler:2.12.7
+- org.scala-lang:scala-library:2.12.7
+- org.scala-lang:scala-reflect:2.12.7
+- org.scala-lang.modules:scala-parser-combinators_2.12:1.1.1
+- org.scala-lang.modules:scala-xml_2.12:1.0.5
Review comment:
```suggestion
- org.scala-lang.modules:scala-xml_2.12:1.0.6
```
combinators is no longer a transtive dependency, and the correct scala-xml
version is 1.0.6.
##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -69,6 +69,11 @@ under the License.
<artifactId>scala-compiler</artifactId>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.scala-lang.modules</groupId>
+
<artifactId>scala-parser-combinators_${scala.binary.version}</artifactId>
Review comment:
please move this down into the `<dependencyManagement>` section; that
way we don't change the structure of the dependency tree, but just modify the
version. (i.e., the dependency tree still shows where this dependency came from)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
