fapaul commented on a change in pull request #17342:
URL: https://github.com/apache/flink/pull/17342#discussion_r717339774
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/fetcher/KafkaSourceFetcherManager.java
##########
@@ -73,7 +73,7 @@ public void commitOffsets(
if (offsetsToCommit.isEmpty()) {
return;
}
- SplitFetcher<Tuple3<T, Long, Long>, KafkaPartitionSplit> splitFetcher
= fetchers.get(0);
+ SplitFetcher<Tuple3<T, Long, Long>, KafkaPartitionSplit> splitFetcher
= getRunningFetcher();
Review comment:
Nit: Does this change have any effect on the fix if not maybe make the
change a separate commit?
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/fetcher/KafkaSourceFetcherManager.java
##########
@@ -73,7 +73,7 @@ public void commitOffsets(
if (offsetsToCommit.isEmpty()) {
return;
}
- SplitFetcher<Tuple3<T, Long, Long>, KafkaPartitionSplit> splitFetcher
= fetchers.get(0);
+ SplitFetcher<Tuple3<T, Long, Long>, KafkaPartitionSplit> splitFetcher
= getRunningFetcher();
Review comment:
Can you explain a bit more why this is a performance improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
