matriv commented on a change in pull request #17341:
URL: https://github.com/apache/flink/pull/17341#discussion_r717367218
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java
##########
@@ -261,6 +248,14 @@ TestSpec withFunction(Class<? extends UserDefinedFunction>
functionClass) {
TestSpec testTableApiResult(
Expression expression, Object result, AbstractDataType<?>
dataType) {
+ return testTableApiResult(
+ new Expression[] {expression},
+ new Object[] {result},
+ new AbstractDataType<?>[] {dataType});
+ }
+
+ TestSpec testTableApiResult(
+ Expression[] expression, Object[] result,
AbstractDataType<?>[] dataType) {
Review comment:
Don't have any objection, just chose arrays here to avoid the overhead
of List objects especially for the common cases of only one element, but
considering it's test, Lists are nicer indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
